Skip to content

Allow importing external references #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

chris-armstrong
Copy link

This is a replacement for #433 , using a library to parse external and remote $ref instances so that an openapi.yml can be split up at development time, but reassembled for the purposes of generating types.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #573 (87728f1) into master (f864007) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   90.83%   90.86%   +0.02%     
==========================================
  Files         107      107              
  Lines        1320     1324       +4     
  Branches      235      235              
==========================================
+ Hits         1199     1203       +4     
  Misses        121      121              
Impacted Files Coverage Δ
src/utils/getOpenApiSpec.ts 84.61% <100.00%> (+6.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f864007...87728f1. Read the comment docs.

@chris-armstrong chris-armstrong marked this pull request as ready for review February 18, 2021 04:16
@ferdikoomen
Copy link
Owner

Looks good @chris-armstrong

@ferdikoomen ferdikoomen merged commit 1ef9bd9 into ferdikoomen:master Feb 18, 2021
@ferdikoomen
Copy link
Owner

@chris-armstrong I already bumped the version number, i was thinking should we add a small description in the README about the 'auto-bundle' feature?

@chris-armstrong
Copy link
Author

@chris-armstrong I already bumped the version number, i was thinking should we add a small description in the README about the 'auto-bundle' feature?

Sure, I'll updated my PR with a quick note about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants